Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENTELEMETRY_COLLECTOR_CONFIG_FILE env var name is ambiguous #2899

Open
garysassano opened this issue Nov 20, 2024 · 0 comments
Open

OPENTELEMETRY_COLLECTOR_CONFIG_FILE env var name is ambiguous #2899

garysassano opened this issue Nov 20, 2024 · 0 comments

Comments

@garysassano
Copy link

The ADOT collector supports the following types of confmap providers: file, env, yaml, http, https, and s3.

However, the environment variable name OPENTELEMETRY_COLLECTOR_CONFIG_FILE might misleadingly suggest that it is only applicable to the file provider. A more generic name, such as OPENTELEMETRY_COLLECTOR_CONFIG, would be more appropriate.

Additionally, I find the documentation somewhat inconsistent. It initially states that the config should be provided in the <scheme>:<value> format but later shows examples where specifying the scheme is optional in certain cases:

image

To address this inconsistency, I recommend making it mandatory to define the scheme type explicitly.

adot-file-provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant