Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should credentials_endpoint have validation that it can only be a private or link local IP, and not a hostname or public IP? #357

Open
PettitWesley opened this issue Oct 5, 2023 · 0 comments

Comments

@PettitWesley
Copy link
Contributor

Currently, we have credentials_endpoint in this output plugin. This supports use cases for custom credential vending.

For a dataplane agent that runs on hosts like Fluent Bit, I wonder if any custom credential vending service should always listen on a link local or private IP or localhost IP. It seems insecure and never wise to reach out to a public IP or hostname for credentials.

We could add validation to reject the config if the endpoint is not local/private. This would hurt users who have their custom credential server reachable through a private DNS hostname, which seems like a valid and reasonable use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant