Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] SSM Agent can not be installed on Windows with $PSCulture = "de-DE" #604

Open
qoomon opened this issue Dec 6, 2024 · 3 comments · May be fixed by #606
Open

[Bug] SSM Agent can not be installed on Windows with $PSCulture = "de-DE" #604

qoomon opened this issue Dec 6, 2024 · 3 comments · May be fixed by #606

Comments

@qoomon
Copy link

qoomon commented Dec 6, 2024

Because of checking against the output of windows service manager, following checks will not match and therfore start and stop will always fail.

amazon-ssm-agent/agent/setupcli/managers/servicemanagers/windowsmanager.go

Line 51 in f6ab670

if strings.Contains(output, "service has already been started") {

amazon-ssm-agent/agent/setupcli/managers/servicemanagers/windowsmanager.go

Line 72 in f6ab670

if strings.Contains(output, "service is not started") {

@qoomon qoomon changed the title SSM Agent can not be installed on Windows with $PSCulture = "de-DE" [Bug] SSM Agent can not be installed on Windows with $PSCulture = "de-DE" Dec 6, 2024
@qoomon
Copy link
Author

qoomon commented Dec 6, 2024 •
edited
Loading

I think the error code to check should be 2 in both cases

amazon-ssm-agent/agent/setupcli/managers/servicemanagers/windowsmanager.go

Line 67 in f6ab670

if ec == 3521 {

amazon-ssm-agent/agent/setupcli/managers/servicemanagers/windowsmanager.go

Line 46 in f6ab670

if ec == 2182 {

qoomon added a commit to qoomon/amazon-ssm-agent that referenced this issue Dec 6, 2024
@qoomon
fix(windows): refactor start stop agent without relying on $PSCulture…
1ec8754 
… = "en-US"

fixes aws#604
@qoomon qoomon linked a pull request Dec 6, 2024 that will close this issue
Open
@Aperocky
Copy link
Contributor

Thanks, we will look into fixing this.

@qoomon
Copy link
Author

qoomon commented Mar 8, 2025

that is still an issue. Are you gonna fix it or merge me PR any time soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(windows): refactor start and stop agent to not rely on $PSCulture qoomon/amazon-ssm-agent
2 participants
@qoomon @Aperocky