Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-globalize setIoMessageThreshold #32897

Open
HBobertz opened this issue Jan 13, 2025 · 0 comments
Open

De-globalize setIoMessageThreshold #32897

HBobertz opened this issue Jan 13, 2025 · 0 comments
Labels
@aws-cdk/core Related to core CDK functionality effort/medium Medium work item – several days of effort p2

Comments

@HBobertz
Copy link
Contributor

HBobertz commented Jan 13, 2025 •
edited
Loading

Depends on #32816

Today the setIoMessageThreshold function maintains a global variable which is used to globally determine whether a log message should be emitted. This is a problem for the Programmatic Toolkit as globally maintained memory can potentially lead to unexpected behavior especially in multithreaded workloads.

setIoMessageThreshold logic needs to be moved into the IoHost class and specific to that IoHost instance
@HBobertz HBobertz changed the title DeGlobalize setIoMessageThreshold and pass it with IoHost De-globalize setIoMessageThreshold and pass it with IoHost Jan 13, 2025
@HBobertz HBobertz changed the title De-globalize setIoMessageThreshold and pass it with IoHost De-globalize setIoMessageThreshold Jan 13, 2025
@HBobertz HBobertz mentioned this issue Jan 13, 2025
Merged
1 task
@khushail khushail added p2 effort/medium Medium work item – several days of effort @aws-cdk/core Related to core CDK functionality labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/core Related to core CDK functionality effort/medium Medium work item – several days of effort p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HBobertz @khushail