Skip to content

Commit 19e7766

Browse files
authored
Fix new module verification CI and TODOs in pom.xml (#6257)
1 parent d85bab4 commit 19e7766

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

.github/workflows/new-module-verification.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,23 +129,23 @@ jobs:
129129
fi
130130
131131
# 2. Check if added to tests-coverage-reporting pom.xml
132-
if ! grep -q "<module>.*$MODULE_NAME</module>" test/tests-coverage-reporting/pom.xml 2>/dev/null; then
132+
if ! grep -q "<dependency>.*$MODULE_NAME</dependency>" test/tests-coverage-reporting/pom.xml 2>/dev/null; then
133133
echo "::error::Module $MODULE_NAME is not added to tests-coverage-reporting pom.xml"
134134
HAS_ERRORS=1
135135
else
136136
echo "✅ Module is added to tests-coverage-reporting"
137137
fi
138138
139139
# 3. Check if added to aws-sdk-java pom.xml
140-
if ! grep -q "<module>.*$MODULE_NAME</module>" aws-sdk-java/pom.xml 2>/dev/null; then
140+
if ! grep -q "<dependency>.*$MODULE_NAME</dependency>" aws-sdk-java/pom.xml 2>/dev/null; then
141141
echo "::error::Module $MODULE_NAME is not added to aws-sdk-java pom.xml"
142142
HAS_ERRORS=1
143143
else
144144
echo "✅ Module is added to aws-sdk-java pom.xml"
145145
fi
146146
147147
# 4. Check if added to architecture-tests pom.xml
148-
if ! grep -q "<module>.*$MODULE_NAME</module>" test/architecture-tests/pom.xml 2>/dev/null; then
148+
if ! grep -q "<dependency>.*$MODULE_NAME</dependency>" test/architecture-tests/pom.xml 2>/dev/null; then
149149
echo "::error::Module $MODULE_NAME is not added to architecture-tests pom.xml"
150150
HAS_ERRORS=1
151151
else

pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -684,10 +684,6 @@
684684
<exclude>*.internal.*</exclude>
685685
<exclude>software.amazon.awssdk.thirdparty.*</exclude>
686686
<exclude>software.amazon.awssdk.regions.*</exclude>
687-
<!-- TODO revert - Temporarily disable because system setting USER_REGION was removed -->
688-
<exclude>software.amazon.awssdk.utils.JavaSystemSetting</exclude>
689-
<!-- TODO remove once S3ObjectSize is change is merged -->
690-
<exclude>software.amazon.awssdk.services.s3.model.CompleteMultipartUploadRequest</exclude>
691687
</excludes>
692688

693689
<ignoreMissingOldVersion>true</ignoreMissingOldVersion>

0 commit comments

Comments
 (0)