From 467c23f6d90d871dc6dd0f9ea6389b9938e55697 Mon Sep 17 00:00:00 2001 From: Felix Hieber Date: Tue, 8 May 2018 16:42:14 +0200 Subject: [PATCH] Remove overly restrictive check to support early stopping with BLEU (#384) * Remove overly restrictive check to support early stopping with BLEU Removes an overly restrictive check introduced with the train refactoring. Re-allows early stopping w.r.t BLEU. * changelog --- CHANGELOG.md | 4 ++++ sockeye/__init__.py | 2 +- sockeye/training.py | 1 - 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 29588950b..8e2fd4f6a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,10 @@ Note that Sockeye has checks in place to not translate with an old model that wa Each version section may have have subsections for: _Added_, _Changed_, _Removed_, _Deprecated_, and _Fixed_. +## [1.18.10] +### Fixed +- Re-allow early stopping w.r.t BLEU + ## [1.18.9] ### Fixed - Fixed a problem with lhuc boolean flags passed as None. diff --git a/sockeye/__init__.py b/sockeye/__init__.py index efae70d34..ecd67cf47 100644 --- a/sockeye/__init__.py +++ b/sockeye/__init__.py @@ -11,4 +11,4 @@ # express or implied. See the License for the specific language governing # permissions and limitations under the License. -__version__ = '1.18.9' +__version__ = '1.18.10' diff --git a/sockeye/training.py b/sockeye/training.py index dfbac2bf0..67a26d98e 100644 --- a/sockeye/training.py +++ b/sockeye/training.py @@ -880,7 +880,6 @@ def _check_args(self, """ Helper function that checks various configuration compatibilities. """ - utils.check_condition(early_stopping_metric in metrics, "Early stopping metric must be tracked.") utils.check_condition(len(metrics) > 0, "At least one metric must be provided.") for metric in metrics: utils.check_condition(metric in C.METRICS, "Unknown metric to track during training: %s" % metric)