From 5a345f0828615b43b980fe6e79b75a8858e5b2d7 Mon Sep 17 00:00:00 2001 From: Kristaps Kazarevskis Date: Fri, 24 Jan 2020 11:35:24 +0200 Subject: [PATCH 1/2] Update to latest preferred GPT implementation --- packages/gpt-ads/lib/templates/plugin.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/gpt-ads/lib/templates/plugin.js b/packages/gpt-ads/lib/templates/plugin.js index b405247..0c50104 100644 --- a/packages/gpt-ads/lib/templates/plugin.js +++ b/packages/gpt-ads/lib/templates/plugin.js @@ -31,13 +31,13 @@ export default async function (ctx, inject) { // Inject GPT lib const gptLibScript = { id: GPT_LIB_SCRIPT_ID, - src: 'https://www.googletagservices.com/tag/js/gpt.js', + src: 'https://securepubads.g.doubleclick.net/tag/js/gpt.js', async: true, }; injectScript(gptLibScript); // Inject GPT init script - let gptInitScriptHtml = 'var googletag = googletag || {};googletag.cmd = googletag.cmd || [];'; + let gptInitScriptHtml = 'window.googletag = window.googletag || {cmd: []};'; if (debug) { gptInitScriptHtml += 'googletag.cmd.push(function(){googletag.openConsole();});'; } From 211a8430695bf07dc57b1ce3852e021e98e5dd2f Mon Sep 17 00:00:00 2001 From: Kristaps Kazarevskis Date: Fri, 24 Jan 2020 11:39:19 +0200 Subject: [PATCH 2/2] Added refreshOnrouteChange prop to gpt-ad component --- packages/gpt-ads/README.md | 5 +++++ packages/gpt-ads/lib/templates/component.js | 14 ++++++++++++++ 2 files changed, 19 insertions(+) diff --git a/packages/gpt-ads/README.md b/packages/gpt-ads/README.md index 1dcd544..9bc8999 100755 --- a/packages/gpt-ads/README.md +++ b/packages/gpt-ads/README.md @@ -153,6 +153,11 @@ Debounce duration between each window resize handling. Override `collapseEmptyDivs` option at the slot's level. +#### refreshOnRouteChange + +- Type: `Boolean` +- Default: `false` + ### Examples diff --git a/packages/gpt-ads/lib/templates/component.js b/packages/gpt-ads/lib/templates/component.js index fe0d392..7132097 100644 --- a/packages/gpt-ads/lib/templates/component.js +++ b/packages/gpt-ads/lib/templates/component.js @@ -42,6 +42,11 @@ export default { required: false, default: null, }, + refreshOnRouteChange: { + type: Boolean, + required: false, + default: false + }, }, computed: { networkCode() { @@ -168,6 +173,15 @@ export default { return index; }, }, + + watch: { + '$route.path': function() { + if (this.refreshOnRouteChange) { + this.refreshSlot(); + } + } + }, + mounted() { if (!window.googletag) { return;