Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Handle failed deposit txs made in step 2 of the transaction status screen #98

Open
11 tasks done
canhtrinh opened this issue Jan 23, 2022 · 1 comment
Open
11 tasks done

Comments

@canhtrinh
Copy link
Collaborator

canhtrinh commented Jan 23, 2022

Description

  • Some have reported that when deposits are made in step 2, the UI either doesn't update correctly with proper messaging or gives a non-helpful response.
  • When a user makes a deposit either by IBC transfer or Metamask transfer to make the deposit in step 2, and if the transaction isn't successful, we should say why and also log it to datadog.

Possible reasons for a failed deposit tx:

  • IBC
    • account sequence mismatch - [@joão Sousa] reported
    • insufficient funds issue - [@jackson] reported
    • out of gas issues (known from before
    • outright rejecting a tx from Keplr
  • EVM
    • insufficient funds issue - [@jackson] reported
    • out of gas issues (known from before
    • outright rejecting a tx from Metamask

Todos

  • Set up log controller on the rest server to receive incoming messaging from the UI
  • Define possible failure cases for Metamask transactions
  • Define possible failure cases for IBC transfer transactions
  • Log those occurrences to the rest-server so they show up in datadog

Steps to Test

Expected Behaviour

Other Notes

@canhtrinh
Copy link
Collaborator Author

I commited this directly here: b89114b and deployed to testnet. Will do some testing tomorrow and deploy to mainnet then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant