Merge pull request #319 from alltilla/s3-workaround-comment-and-newsfile

S3 workaround comment and newsfile

modules/python-modules/syslogng/modules/s3/s3_destination.py

@@ -249,6 +249,9 @@ def open(self) -> bool:
         if self.is_opened():
             return True
 
+        # NOTE: Creating a client via a Session object does some unusual caching, which increases memory usage
+        # NOTE: each reload.  Because of this, we only create Session object if the role is set, and in that case
+        # NOTE: the memory usage is expected to behave unusually.  Sometime we should investigate this further.
         if self.role != "":
             self.session = Session(
                 aws_access_key_id=self.access_key if self.access_key != "" else None,

news/bugfix-318.md

@@ -0,0 +1,6 @@
+`s3()`: Eliminated indefinite memory usage increase for each reload.
+
+The increased memory usage is caused by the `botocore` library, which
+caches the session information. We only need the Session object, if
+`role()` is set. The increased memory usage still happens with that set,
+currently we only fixed the unset case.