Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up design #24

Open
ajrobbins opened this issue Jun 29, 2017 · 2 comments
Open

Clean up design #24

ajrobbins opened this issue Jun 29, 2017 · 2 comments
Assignees

Comments

@ajrobbins
Copy link
Contributor

Clean up styling of sensor values, headers/subtitles, and "sensors" screen.

@kellyi
Copy link
Contributor

kellyi commented Jun 30, 2017

There are currently four states of the text:

  • no text shown (which happens for the "Sensor" spoke or if the app fails altogether)
  • primary Schuylkill sensor text
  • backup Delaware sensor text
  • fallback hard-coded values text

The app tries the primary url first, then the secondary url, then uses the fallback values. You can force it to hit the secondary and fallback values by messing with the URL endpoints here:

https://github.com/azavea/pwd-river-dispatches/blob/develop/usgs-details.html#L55

Dropping .usgs from the middle of them works, as it hits an invalid url

@jfrankl jfrankl assigned alexelash and unassigned jfrankl Jun 30, 2017
@ajrobbins
Copy link
Contributor Author

Idea for "Sensors" screen:

Here's the Schuylkill sensor's page with the location of the sensor: https://waterdata.usgs.gov/usa/nwis/uv?01474500

I'm thinking we could use a map image with a map pin to indicate where the sensor is in the river, or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants