Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Sass styles with CSS-in-JS #66

Open
kellyi opened this issue Apr 4, 2019 · 0 comments
Open

Replace Sass styles with CSS-in-JS #66

kellyi opened this issue Apr 4, 2019 · 0 comments

Comments

@kellyi
Copy link
Contributor

kellyi commented Apr 4, 2019

Overview

As noted in #55, the distribution Sass file doesn't seem to minify properly, and the sass output ends up being much larger than the JS component output. Likewise, #51 reports an issue whereby different default installations of Node-Sass on host cause the build to fail. In general the longest part of and build or npm install is the part which rebuilds node-sass from source.

We can circumvent all of these issues by replacing the existing Sass stylesheet with CSS-in-JS styles.

Is your feature request related to a problem? Please describe.

  • sass files don't minify properly, which increases the size of the dependency when imported into other applications
  • node-sass breaks if an existing incompatible version is already installed on hos
  • node-sass is the longest segment of the entire install-build-pipeline

Describe the solution you'd like

Remove node-sass and replace the sass stylesheets with CSS-in-JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant