Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move prettier-loader to devDependencies #72

Open
kellyi opened this issue Apr 9, 2019 · 0 comments
Open

Move prettier-loader to devDependencies #72

kellyi opened this issue Apr 9, 2019 · 0 comments
Labels
bug

Comments

@kellyi
Copy link
Contributor

kellyi commented Apr 9, 2019

Overview

Having prettier-loader under dependencies leads to this warning when using the library in another application:

Screen Shot 2019-04-09 at 1 43 12 PM

It's non-fatal and probably mostly inconsequential but just to be sure we should move the prettier-loader to devDependencies.

Expected Behavior

prettier-loader is in devDependencies & prettier-loader still runs automatically on file system changes.

Actual Behavior

prettier-loader is in dependencies
@kellyi kellyi added the bug label Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kellyi