Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UXE-5813] fix: show name of instance function instead of function on Edge App Rules Engine #1975

Conversation

pauloSF0
Copy link
Contributor

@pauloSF0 pauloSF0 commented Nov 27, 2024

Pull Request

What is the new behavior introduced by this PR?

UXE-5813 fix: run function show the name of the function and not the instance function

Does this PR introduce breaking changes?

  • No
  • Yes

Does this PR introduce UI changes? Add a video or screenshots here.

Gravacao.de.Tela.2024-11-27.as.16.23.02.mov

Does it have a link on Figma?


Checklist

Make sure your pull request fits the checklist below (when applicable):

  • The issue title follows the format: [ISSUE_CODE] TYPE: TITLE
  • Commits are tagged with the right word (feat, test, refactor, etc)
  • Application responsiveness was tested to different screen sizes
  • Code is formatted and linted
  • Tags are added to the PR

These changes were tested on the following browsers:

  • Chrome
  • Edge
  • Firefox
  • Safari

@pauloSF0 pauloSF0 added the bug Something isn't working label Nov 27, 2024
@pauloSF0 pauloSF0 self-assigned this Nov 27, 2024
@pauloSF0 pauloSF0 requested review from a team as code owners November 27, 2024 19:55
Copy link

sonarcloud bot commented Nov 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
14.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

HerbertJulio
HerbertJulio previously approved these changes Nov 29, 2024
lfsigreja
lfsigreja previously approved these changes Dec 2, 2024
Copy link
Contributor

@lfsigreja lfsigreja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@aloisio-m-bastian aloisio-m-bastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

não sei se foi alterado em outro pr, mas existe um teste cypress de rules engine que aguarda a resposta da chamada do endpoint, é necessário alterar lá o nome do endpoint para evitar erros e também remover o xfail (motivo por qual o problema não foi acusado em seu pr)
image

@pauloSF0
Copy link
Contributor Author

pauloSF0 commented Dec 4, 2024

Essa tarefa não tem relação com V4, esse alteração mencionada faz sentido quando for em relação a migração da mesma.

@pauloSF0 pauloSF0 closed this Dec 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
@pauloSF0 pauloSF0 reopened this Dec 4, 2024
@vinigfer vinigfer changed the title [UXE-5813] fix: run function show the name of the function and not the instance function [UXE-5813] fix: show name of instance function instead of function on Edge App Rules Engine Dec 6, 2024
@vinigfer vinigfer dismissed aloisio-m-bastian’s stale review December 6, 2024 14:31

Fix v3 nos testes será feito em outra issue

@pauloSF0 pauloSF0 dismissed stale reviews from lfsigreja and HerbertJulio via 62e7388 December 6, 2024 14:46
HerbertJulio
HerbertJulio previously approved these changes Dec 10, 2024
@vinigfer vinigfer merged commit 0231dff into dev Dec 12, 2024
8 of 12 checks passed
@vinigfer vinigfer deleted the UXE-5813-run-function-show-the-name-of-the-function-and-not-the-instance-function branch December 12, 2024 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

6 participants