Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate queryRemoveLiquidityRecovery for v3 #531

Open
brunoguerios opened this issue Dec 11, 2024 · 0 comments · May be fixed by #533
Open

Remove duplicate queryRemoveLiquidityRecovery for v3 #531

brunoguerios opened this issue Dec 11, 2024 · 0 comments · May be fixed by #533
Assignees

Comments

@brunoguerios
Copy link
Member

This method was implemented when we didn't have query available for removeLiquidityRecovery, but now we do and it's already being handled inside the default Remove Liquidity query, so we can remove it as duplicate.

Note: v2 would still need the custom implementation of query for remove liquidity recovery, as there's no actual query available on vault (v2). But in any case, we should consider a refactor where queryRemoveLiquidityRecovery custom implementation is moved to inside query to make sure both v2 and v3 share the same external interface.

@brunoguerios brunoguerios self-assigned this Dec 11, 2024
@brunoguerios brunoguerios linked a pull request Dec 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant