Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompositeLiquidityRouter fixes #1044

Open
jubeira opened this issue Oct 10, 2024 · 1 comment · May be fixed by #1104
Open

CompositeLiquidityRouter fixes #1044

jubeira opened this issue Oct 10, 2024 · 1 comment · May be fixed by #1104
Assignees
@joaobrunoah @elshan-eth

Comments

@jubeira
Copy link
Contributor

jubeira commented Oct 10, 2024

The current CompositeLiquidityRouter routers need some work in certain areas:

  • We should try to make it compile with viaIR, as it's now above the bytecode limit already
  • Figure out if we can reuse some code across routers
  • Make use of wethIsEth flag properly in every case, and check that it returns native eth properly
@elshan-eth elshan-eth mentioned this issue Oct 21, 2024
Closed
12 tasks
@joaobrunoah joaobrunoah self-assigned this Nov 5, 2024
@elshan-eth elshan-eth linked a pull request Nov 13, 2024 that will close this issue
Draft
12 tasks
@elshan-eth elshan-eth reopened this Nov 21, 2024
@elshan-eth
Copy link
Contributor

In this task only refactoring remains, which was moved to post lunch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaobrunoah joaobrunoah

@elshan-eth elshan-eth

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@EndymionJkb @jubeira @joaobrunoah @elshan-eth