Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factory is an implicit return value of createPool for base pool test #1180

Open
jubeira opened this issue Dec 12, 2024 · 0 comments
Open

Factory is an implicit return value of createPool for base pool test #1180

jubeira opened this issue Dec 12, 2024 · 0 comments
Assignees

Comments

@jubeira
Copy link
Contributor

jubeira commented Dec 12, 2024

For base pool tests, we need to assign the factory inside createPool. This is an implicit return value, and it's not obvious for builders trying to reuse base pool test.

See https://github.com/balancer/balancer-v3-monorepo/blob/main/pkg/pool-weighted/test/foundry/WeightedPool.t.sol#L70 and https://github.com/balancer/balancer-v3-monorepo/blob/main/pkg/vault/test/foundry/utils/BasePoolTest.sol#L56.

Let's make it more explicit. I don't think we need to add the value to createPool, but maybe create another method createFactory that is specific to base pool tests would be better. Pool specializations will need to override it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants