Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send V3 spells for review #178

Closed
viniabussafi opened this issue Nov 20, 2024 · 8 comments
Closed

Send V3 spells for review #178

viniabussafi opened this issue Nov 20, 2024 · 8 comments
Assignees
@viniabussafi

Comments

@viniabussafi
Copy link
Member

No description provided.

@viniabussafi viniabussafi self-assigned this Nov 20, 2024
@viniabussafi
Copy link
Member Author

commiting on this branch.

Order of commits will be:

  • macros
  • spells
  • sources / schemas

@viniabussafi
Copy link
Member Author

Spells/schemas/sources are built

@viniabussafi
Copy link
Member Author

viniabussafi commented Nov 26, 2024 •
edited
Loading

Still missing:

  • aave tokens (spell and then adding as pricing source to downstream spells)
  • buffer balances spell

@viniabussafi
Copy link
Member Author

writing a doc to make reviewer's life easier

@viniabussafi
Copy link
Member Author

Will still make a little review of my own until EOD

@viniabussafi
Copy link
Member Author

finished my review and pushed changes

@viniabussafi
Copy link
Member Author

jeff will start his review on monday

@viniabussafi
Copy link
Member Author

reviewed and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viniabussafi viniabussafi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@viniabussafi