Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't compile with boost 1.67 #55

Open
Fierthraix opened this issue Jun 26, 2018 · 1 comment · May be fixed by #56
Open

Doesn't compile with boost 1.67 #55

Fierthraix opened this issue Jun 26, 2018 · 1 comment · May be fixed by #56

Comments

@Fierthraix
Copy link

The release of boost 1.67 fixes an issue where floating point values are automatically converted into integers for the constructors of boost::posix_time::time_duration, and helper functions like boost::posix_time::microseconds(long). This causes errors when special values (NaN, -∞, etc) are passed to it.

Currently the value double limit value in Baz Burster get passed to boost::posix_time::microseconds(limit * 1e6), which isn't auto converting anymore.

This is the current compilation error.

/home/user/projects/gr-baz/src/gr-baz/lib/baz_burster.cc: In member function ‘virtual int baz_burster::general_work(int, gr_vector_int&, gr_vector_const_void_star&, gr_vector_void_star&)’:
/home/user/projects/gr-baz/src/gr-baz/lib/baz_burster.cc:225:62: error: no matching function for call to ‘boost::date_time::subsecond_duration<boost::posix_time::time_duration, 1000000>::subsecond_duration(double)’
       if (diff >= boost::posix_time::microseconds(limit * 1e6))
@Fierthraix Fierthraix linked a pull request Jun 26, 2018 that will close this issue
@julien-noblet
Copy link

Please see #56 seems to be a good fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants