You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 2, 2023. It is now read-only.
Your library looks very promising. I like the idea of a navigation bar I can plug into my site without being forced to use a bloated framework.
But one of the problems I have with some of the frameworks is that they are so verbose. It's not enough to say that something is a <button>; you have to say <button class="btn"> as the the element name weren't enough. It adds more cruft to the document for no reason.
I'm surprised that luxbar does the same thing. If I have a <div>, I understand that I need to use <div class="luxbar">. That's understandable. But if I have a <ul class="luxbar-navigation">, why must I use <li class="luxbar-item"> for each item? Shouldn't each <li> be a luxbar item by default? To me that's redundant.
I understand that there are other options such as <li class="luxbar-header">, but the CSS should be able to make the "luxbar-item" style the default.
Sorry for the later reply and thanks for sharing your ideas/opinion. I totally agree with you on this. Luxbar hasn't been updated since May, 2017 so I really need to get on this and do a major version update. I have new ideas to implement and issues (like what you mentioned) to solve so thanks again for the feedback and stay tuned for the version update.
I will leave this issue open until the rewrite happens.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Your library looks very promising. I like the idea of a navigation bar I can plug into my site without being forced to use a bloated framework.
But one of the problems I have with some of the frameworks is that they are so verbose. It's not enough to say that something is a
<button>
; you have to say<button class="btn">
as the the element name weren't enough. It adds more cruft to the document for no reason.I'm surprised that luxbar does the same thing. If I have a
<div>
, I understand that I need to use<div class="luxbar">
. That's understandable. But if I have a<ul class="luxbar-navigation">
, why must I use<li class="luxbar-item">
for each item? Shouldn't each<li>
be a luxbar item by default? To me that's redundant.I understand that there are other options such as
<li class="luxbar-header">
, but the CSS should be able to make the "luxbar-item
" style the default.Look at the example on the main page:
Why?! So much redundancy. Why can't I do this?
After all, the first
<li>
this example is itself in a luxbar navigation, so even it doesn't need aluxbar-item
.The text was updated successfully, but these errors were encountered: