Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi from the author! 👋 #1

Open
timClicks opened this issue Nov 9, 2017 · 5 comments
Open

Hi from the author! 👋 #1

timClicks opened this issue Nov 9, 2017 · 5 comments

Comments

@timClicks
Copy link

Hi Bogdan, just a note to say hello :)

It's amazing that you've taken the time to compile this repo. If anything in the MEAP/book fails to build, feel free to ping me and I'll make sure it gets fixed :)

Some comments/questions:

  • The code style for the book is readability. Were any of the examples difficult to follow?
  • The source code folder actually includes several snippets that are not available in the book—the text was edited away & I will clean up the source code materials when the book is closer to publication—are they included in this repo?
  • How are you finding the book?

Lastly, Manning is the copyright holder for the book, including its code. I recommend checking with them about this. I think that there is a blanket permission in the book, but I'm not sure about the MEAP version,

@barabadzhi
Copy link
Owner

Hi Tim!
Nice to have you here! 🙂 🍻 🙂

Closer to the point:

  • Readability is quite nice and examples are easy to follow. But, probably, I'm not really a person to ask, cause this is not my first Rust book. I personally find it more relaxing and not so in-depth dive into Rust than the official one (or is it just the first chapters impression? 🤔). At this point I will probably recommend it for a newcomer, who wants a soft start with a language. 💯

  • Source code is also OK. I don't remember noticing any big (at least) errors, but will probably recommend running it through rustfmt + clippy once again before the release. 👷

  • This repo didn't contain snippets not available in the book. I didn't looked at the provided source code (at least for now).

  • I probably already answered this question earlier. 🙂

I don't really think I should check it out on copyrights, cause I don't sell it anyhow. I hand-write all myself and it is really not a one-to-one copy either. For example, I like to use names beginning with underscore, then global compiler relaxation directive. For clearance, I also include link to the book for anyone interested. 😉

Thank you for your work! 🎊

@timClicks
Copy link
Author

Thanks for the kind words. Glad to hear that you're enjoying the read.

Just a note on formatting.. the Manning publishing requirements mean that sometimes I need to neglect the rustfmt rules.

Rust in Action is intentionally different than the other resources available. Its (tacit) aim is programmers from dynamic languages who are trying to learn about the Rust/Go/D/Swift/C++17 space. That's why it might come across as a little less in-depth. Also, I think that it would be naive to think that readers of my work haven't already read through read through the official book and perhaps Rust by Example. So I've attempted to avoided duplicating lots of content.

@barabadzhi
Copy link
Owner

@timClicks Listing 5.5. u16 Bit Patterns uses different variable names thus will not compile.
Needs a typo fix. 🐛

@barabadzhi
Copy link
Owner

Hi @timClicks!
Listing 6.2 needs a println! args fix. 🐛
Listing 6.15 probably needs a workaround of nasty mesa bug on Linux. 🐛 🐧

@Cxarli
Copy link

Cxarli commented May 2, 2018

The nasty mesa bug @barabadzhi talked about has been fixed with mesa 18.*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants