Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing types #69

Open
gurkerl83 opened this issue Oct 20, 2020 · 1 comment
Open

Missing types #69

gurkerl83 opened this issue Oct 20, 2020 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gurkerl83
Copy link

gurkerl83 commented Oct 20, 2020

Hello, I'm playing with your library, and I noticed that the properties created for the interface RESQNode must be wrong. There are no byProps or byState properties. It is possible to bend component to any and then call byProps and it will work, but it would be better if your javascript functions are offered the same typescript types.

const nodes = resq$(name);
const component = (nodes as any).byProps({a: 1});

Would be great if you can fix this, thanks!

@baruchvlz baruchvlz added the good first issue Good for newcomers label Oct 21, 2020
@baruchvlz
Copy link
Owner

Thanks for reporting, we're currently working on migrating the library to TypeScript for v2. In the mean time, if you want to fix the types in index.d.ts PRs are always welcomed :).

@baruchvlz baruchvlz added the help wanted Extra attention is needed label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants