Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node remove should require a node name #31

Open
seanjensengrey opened this issue Aug 6, 2016 · 2 comments
Open

node remove should require a node name #31

seanjensengrey opened this issue Aug 6, 2016 · 2 comments

Comments

@seanjensengrey
Copy link

riak-mesos node remove

will remove riak-default-1 by default when no name is provided.

On subsequent, rexecution

$ riak-mesos node remove
Resource at http://10.1.12.145:31936/api/v1/clusters/default/nodes/riak-default-1 was not found (Status Code: 404)

The command should require an explicit node name, for example

riak-mesos node remove --node riak-cluster-4
@sanmiguel
Copy link
Contributor

You're right, this should be a required argument. In which case, I think we
should promote it to a positional arg, not a switch: riak-mesos node remove riak-default-1

That's 7 less characters to type!

I'm tempted to suggest that this applies to all node commands (except add).

Thoughts?

On Sat, 6 Aug 2016, 13:41 Sean Jensen-Grey, [email protected]
wrote:

riak-mesos node remove

will remove riak-default-1 by default when no name is provided.

On subsequent, rexecution

$ riak-mesos node remove
Resource at http://10.1.12.145:31936/api/v1/clusters/default/nodes/riak-default-1 was not found (Status Code: 404)

The command should require an explicit node name, for example

riak-mesos node remove --node riak-cluster-4


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#31, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ACBkRmKCz3Ka6SDHYZ4xNeVxflEOFiW0ks5qdHLhgaJpZM4JeQ0n
.

@seanjensengrey
Copy link
Author

and if we have a bare

riak-mesos node remove

it should actually call

riak-mesos node list along with help output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants