Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some little issues #4

Open
hafezd opened this issue Aug 25, 2015 · 1 comment
Open

some little issues #4

hafezd opened this issue Aug 25, 2015 · 1 comment

Comments

@hafezd
Copy link

hafezd commented Aug 25, 2015

I'v tested live example and noticed some issues:

  • values haven't been trimmed and there are unwanted spaces on both sides of them
  • averageUserRating is rounded, for example 4 instead of 4.1
  • please format price value to "free" instead of " Install " for free apps
  • what is the default currency you use for non-free apps? (I see 0.85 in price value for a $0.99 app, check this as an example) lsn't it better to use formatted price?
  • break lines are removed in description value and there's no space between them
  • is it possible to include 'updated' date?
  • is it possible to include 'Content Rating'?
  • viewUrl value is incomplete (it doesn't have package name inserted at the end)
  • use UTF-8 encoding (other languages are not supported, check this as an example)

thank you so much for this project, it saved me a lot of time :)

@basiclines
Copy link
Owner

Totally agree @hafezdivandari i'll try to make this bugfixes for the next release. Anyway a PR is always welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants