Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow import of sheets with no header row #186

Open
optroodt opened this issue Jul 21, 2020 · 3 comments
Open

[Feature] Allow import of sheets with no header row #186

optroodt opened this issue Jul 21, 2020 · 3 comments
Labels
documentation 📖 Improvements or additions to documentation enhancement ✨ New feature or request good first issue 🥇 Good for newcomers
Milestone

Comments

@optroodt
Copy link
Collaborator

Configurable header row
I can imagine having a sheet that does now have a header row. Currently that row would be skipped, resulting in data loss. Ideally the .yml config should have an option to indicate if the first row is a header (default) or not.

@bastienboutonnet bastienboutonnet added documentation 📖 Improvements or additions to documentation enhancement ✨ New feature or request good first issue 🥇 Good for newcomers labels Jul 21, 2020
@bastienboutonnet bastienboutonnet added this to the Nicolas Jaar milestone Jul 21, 2020
@bastienboutonnet
Copy link
Owner

Great one, thanks @optroodt should be really quick to add that so I'll make sure it makes it into the next release

@jflairie
Copy link
Contributor

jflairie commented Aug 10, 2020

@optroodt can you provide a use case? As there are no column names to grab, and as Snowflake requires column names to create a table, would you like the ability to provide column names in the sheets.yml?

@bastienboutonnet
Copy link
Owner

One of the things we should definitely do is to ensure that columns are named in a consistent manner.

When pandas is not given a header it will create integer columns which are really quite annoying. We should therefore quickly replace the columns with a schema such as column_<index>.

We then should allow users to provide a list of columns names in the sheets.yml config. If they do not then the predictable naming schema will ensure that when we push the data to the database we can have predictable columns.

@bastienboutonnet bastienboutonnet added this to the Objekt milestone Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📖 Improvements or additions to documentation enhancement ✨ New feature or request good first issue 🥇 Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants