Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support more specific datatypes #189

Open
jflairie opened this issue Aug 11, 2020 · 1 comment
Open

Feature: support more specific datatypes #189

jflairie opened this issue Aug 11, 2020 · 1 comment
Labels
documentation 📖 Improvements or additions to documentation enhancement ✨ New feature or request good first issue 🥇 Good for newcomers help wanted 👋🏻 Extra attention is needed
Milestone

Comments

@jflairie
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As of now numerical columns are imported with a lot of decimals, even when not needed. (ex: 0.8 will be imported as 0.800000000000000000). It decreases the readability and consumes unnecessary storage space on the database. Similarly, we can do the same with other data types like varchar.

Describe the solution you'd like
Add the ability to specify more specific datatypes in the sheets.yml configuration.

@bastienboutonnet bastienboutonnet added this to the Nicolas Jaar milestone Aug 11, 2020
@bastienboutonnet bastienboutonnet added documentation 📖 Improvements or additions to documentation enhancement ✨ New feature or request good first issue 🥇 Good for newcomers help wanted 👋🏻 Extra attention is needed labels Aug 11, 2020
@bastienboutonnet
Copy link
Owner

bastienboutonnet commented Aug 11, 2020

This should be very doable! As of version >=1 we are using SQL Alchemy data types which should make imposing this pretty easy. I would first tackle the numerical aspect and then the varchar.

I think it might also be good to implement support for INTs as we currently don't have a type for this.

Most of the magic is likely to happen in: https://github.com/bastienboutonnet/sheetwork/blob/dev/objekt/core/adapters/impl.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📖 Improvements or additions to documentation enhancement ✨ New feature or request good first issue 🥇 Good for newcomers help wanted 👋🏻 Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants