Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into making sure that we can avoid SQL injections #255

Open
bastienboutonnet opened this issue Nov 23, 2020 · 0 comments
Open

Look into making sure that we can avoid SQL injections #255

bastienboutonnet opened this issue Nov 23, 2020 · 0 comments
Labels
help wanted 👋🏻 Extra attention is needed ⚗️ research/follow up security Pull requests that address a security vulnerability triaged: no

Comments

@bastienboutonnet
Copy link
Owner

We're using some f-strings in the connection.execute and although the engine is created by SQL alchemy I'm actually not sure if some nasty sql could not be passed via the target_schema and target_database parameters which can be overriden by users via CLI arguments.
@bastienboutonnet bastienboutonnet added help wanted 👋🏻 Extra attention is needed ⚗️ research/follow up security Pull requests that address a security vulnerability triaged: no labels Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted 👋🏻 Extra attention is needed ⚗️ research/follow up security Pull requests that address a security vulnerability triaged: no
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bastienboutonnet