Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wanted: osqp-eigen #3488

Open
1 task
kgreenek opened this issue Dec 25, 2024 · 3 comments
Open
1 task

wanted: osqp-eigen #3488

kgreenek opened this issue Dec 25, 2024 · 3 comments
Labels
module wanted Users want a certain module to be available in the BCR, contributions are welcome!

Comments

@kgreenek
Copy link
Contributor

Module location

https://github.com/robotology/osqp-eigen

Link to bzlmod issue in the module's repository

No response

Any other context to provide?

No response

Fund our work

  • Sponsor our community's open source work by donating a feature bounty
@kgreenek kgreenek added the module wanted Users want a certain module to be available in the BCR, contributions are welcome! label Dec 25, 2024
@traversaro
Copy link

I looked into this in #3353 but I am not a bazel expert, so if you have any suggestion feel free to weigh in!

@kgreenek
Copy link
Contributor Author

I looked into this in #3353 but I am not a bazel expert, so if you have any suggestion feel free to weigh in!

Happy to contribute. Those linker errors are strange indeed.

I have a BUILD.bazel file that looks like this, which I have been using for quite some time:

cc_library(
    name = "osqp-eigen",
    srcs = glob(["src/*.cpp"]),
    hdrs = glob([
        "include/OsqpEigen/*.h",
        "include/OsqpEigen/*.hpp",
        "include/OsqpEigen/*.tpp",
    ]),
    defines = [
        # Uncomment this to enable debug printing for testing.
        #"OSQP_EIGEN_DEBUG_OUTPUT",
        "OSQP_EIGEN_OSQP_IS_V1",
    ],
    includes = ["include"],
    visibility = ["//visibility:public"],
    deps = [
        "@eigen",
        "@osqp",
    ],
)

It's worth saying that I am using the latest version on main for both osqp and osqp-eigen. I had issues which I can't remember now when using the latest osqp release (which is quite old now).

@kgreenek
Copy link
Contributor Author

I just had a look at the osqp BUILD.bazel file in bcr, and it does look like some issues might need to be addressed there.

I'm happy to take a look, but I'd rather use the latest commit on main because they cleaned up a lot of stuff since the 0.6.3 release.

Unfortunately, they haven't release v1.0 yet.

What would be the protocol for me to release a version to BCR, which is just a commit hash from main? Is that allowed, or should I keep this internal to my own repo until they publish a formal release upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module wanted Users want a certain module to be available in the BCR, contributions are welcome!
Projects
None yet
Development

No branches or pull requests

2 participants