-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kotlin rules and android. #4535
Comments
/cc @aj-michael Any idea on this? Thanks! |
Hi @hsyed. Regarding "I was expecting the android rules to just accept JavaInfo" - unfortunately that is not the case. I believe it should be the case, but noone has done the work to make it so. As a workaround, you can just wrap your jar in one of the rules that Android does accept. In particular, you could create a java_library with no sources that exports your kotlin_library. And then depend on that from the android_* rules. If someone were to take charge of the android facet of the kotlin rules, I would be happy to advise. However, I don't think I currently have the bandwidth to do it myself. |
@aj-michael that pattern would work as a work around for now -- I don't think such a macro layer should be introduced in the new rules. If we added such macros they would need to be integration tested in the Kotlin rules repo and it will also make developing new features more complicated (--e.g., Kapt). Until |
Android support has landed. Closing this. |
I'm working on new bazel rules for Kotlin and an extension to the intellij plugin. The android rules in 0.8.1 are not accepting jars built from the Kotlin rules. The
kotlin_library
rule return aJavaInfo
provider, and I was expecting the android rules to just acceptJavaInfo
.These rules might be upstreamed into the bazelbuild org soon (@davidstanke). I don't do any android development myself so it would be good if someone can take charge of the android facet of the rules.
There is more info here hsyed/rules_kotlin#8.
The text was updated successfully, but these errors were encountered: