Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove boostwrap dependency #23

Open
koszulordie opened this issue Oct 7, 2024 · 0 comments
Open

Remove boostwrap dependency #23

koszulordie opened this issue Oct 7, 2024 · 0 comments
Labels
invalid This doesn't seem right

Comments

@koszulordie
Copy link
Collaborator

The boostwrap package used in containers_build/boostdm/training.py that wraps a Classifier instance comes with the inconvenience of adding an additional dependency layer. There is not a big semantic difference between calling boostwrap and xgb. Moreover, boostwrap is used only once. Therefore, I propose to eliminate this dependency

@koszulordie koszulordie added the invalid This doesn't seem right label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants