Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search for conditions returns 'bad request' #33

Open
areisle opened this issue Feb 3, 2022 · 0 comments
Open

search for conditions returns 'bad request' #33

areisle opened this issue Feb 3, 2022 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@areisle
Copy link
Collaborator

areisle commented Feb 3, 2022

Describe the bug
when you search for a condition on the new statement page, if you type less than 3 characters it sends a search with keyword = '' which the api then returns as a bad request

To Reproduce

Steps to reproduce the behaviour:

  1. go to /new/statment
  2. type a character in the 'conditions' field
  3. See error in console
    graphkb-bug-new-statement-bad-request-searching-conditions

Expected behaviour
it should not make a search request a all if the user hasn't typed 3 or more characters
and should have some message visible to the user that this is a requirement to see results

Versions (please complete the following information):
tested on dev deployment https://graphkbdev.bcgsc.ca/query-advanced in chrome

Version: dev (f72972b)

@areisle areisle added the bug Something isn't working label Feb 3, 2022
@creisle creisle added the only-affects-dev Only affects the unreleased dev version and not the current production version of the code label Mar 12, 2022
@creisle creisle added this to the v4.3.0 milestone Mar 12, 2022
@creisle creisle mentioned this issue Apr 18, 2022
@kttkjl kttkjl self-assigned this Apr 26, 2022
@areisle areisle removed the only-affects-dev Only affects the unreleased dev version and not the current production version of the code label May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants