Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent editing of displayName field #61

Open
areisle opened this issue May 3, 2022 · 2 comments
Open

prevent editing of displayName field #61

areisle opened this issue May 3, 2022 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@areisle
Copy link
Collaborator

areisle commented May 3, 2022

Describe the bug
when editing a source, user can edit the display name
graphkb-submit-changes-for-source-becomes-disabled

To Reproduce
Steps to reproduce the behaviour:

  1. go to any source record
  2. click edit
  3. type something in display name field

Expected behaviour
should be able to submit changes
should not be able to edit displayName field

Versions (please complete the following information):

Additional context
tested on prod and it doesn't seem to have this issue

@areisle areisle added bug Something isn't working only-affects-dev Only affects the unreleased dev version and not the current production version of the code labels May 3, 2022
@areisle areisle self-assigned this May 3, 2022
@areisle areisle added this to the v4.3.0 milestone May 3, 2022
@creisle
Copy link
Member

creisle commented May 3, 2022

ya, users aren't allowed to manually edit the displayName field. This field should just not allow changes in the first place

@areisle
Copy link
Collaborator Author

areisle commented May 3, 2022

ah, so then this is actually more correct on dev than on master, but should still be changed to prevent users editing the field in the first place

@areisle areisle changed the title submit changes becomes disabled when updating displayName for source prevent editing of displayName field May 3, 2022
@areisle areisle removed the only-affects-dev Only affects the unreleased dev version and not the current production version of the code label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants