Refactor/upgrade and swap fully to react query #35
Conversation
|
yes, I am planning to |
|
I cannot seem to login anymore with my own credentials or the test ones. I see the following error
|
|
I remember fixing this problem. I think when I was cleaning up the commits after testing by squashing some of them I must have accidentally done something. I'm going through and retesting everything again |
this required moving all existing queries that weren't already to use react-query
had just chosen the same version as another project before, but it looks like there was some important bug fixes to select between that version and this one
areisle
force-pushed
the
refactor/upgrade-and-swap-fully-to-react-query
branch
from
566ebd2 to
3d44e44
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## develop #35 +/- ##
===========================================
+ Coverage 55.88% 56.60% +0.71%
===========================================
Files 108 108
Lines 4194 4072 -122
Branches 1258 1242 -16
===========================================
- Hits 2344 2305 -39
+ Misses 1575 1503 -72
+ Partials 275 264 -11
Continue to review full report at Codecov.
|
|
I have fixed the auth issue and another I found retesting with the graph, and have retested the entire checklist. I also rebased to get latest commits from develop before retesting |
|
Almost all the pages I tested work now
But the import page is broken, you cannot navigate to it at all. I've attached the console log |
|
This comment has been minimized.
This comment has been minimized.
closes #27
this removes all leftover dependencies on abort controllers and swaps them to react query
it also updates to react-query v3 to be able to take advantage of the
selectoptionI did a fair bit of manual testing for this PR which I've listed below:
statements
records
about
query
advanced query
admin
graph view
if there's any other cases you feel should manually be tested let me know