-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/kbdev 1227 signature support #42
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #42 +/- ##
===========================================
- Coverage 86.15% 86.05% -0.10%
===========================================
Files 18 18
Lines 2196 2252 +56
===========================================
+ Hits 1892 1938 +46
- Misses 304 314 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
f"unable to find the gene ({reference_name}) or any equivalent representations" | ||
) | ||
if reference_class == 'Signature': | ||
# TODO: tree-traversal for equivalent signatures; KBDEV-1263 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while KBDEV-1263 is not done, what's the difference between the output from the query below and get_equivalent_terms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point!
Based on get_terms_set(), I just assumed that all these vocab functions was only meant to be used with the Vocabulary class, but the default can actually be changed to any child class of Ontology for most of them, so I'll use get_equivalent_terms(ontology_class='Signature') here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just closed KBDEV-1263
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could signatures be added to the report data for tests in test_upload? In an ideal world test_main as well but test_upload at least will not run automatically so won't hold up github actions while ipr-api prod is not yet updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes seem fine.
My only questions would be that there seem to be other similar categories like TMB_HIGH_CATEGORY. Are these signture categories something completely different or similar.
No description provided.