Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/kbdev 1227 signature support #42

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

mathieulemieux
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 85.91549% with 10 lines in your changes missing coverage. Please review.

Project coverage is 86.05%. Comparing base (0efbfaa) to head (cf7af4d).

Files with missing lines Patch % Lines
pori_python/ipr/annotate.py 46.66% 8 Missing ⚠️
pori_python/graphkb/match.py 88.88% 1 Missing ⚠️
pori_python/ipr/inputs.py 96.42% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #42      +/-   ##
===========================================
- Coverage    86.15%   86.05%   -0.10%     
===========================================
  Files           18       18              
  Lines         2196     2252      +56     
===========================================
+ Hits          1892     1938      +46     
- Misses         304      314      +10     
Flag Coverage Δ
unittests 86.05% <85.91%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mathieulemieux mathieulemieux marked this pull request as ready for review November 19, 2024 18:38
@mathieulemieux mathieulemieux self-assigned this Nov 19, 2024
f"unable to find the gene ({reference_name}) or any equivalent representations"
)
if reference_class == 'Signature':
# TODO: tree-traversal for equivalent signatures; KBDEV-1263
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while KBDEV-1263 is not done, what's the difference between the output from the query below and get_equivalent_terms?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!
Based on get_terms_set(), I just assumed that all these vocab functions was only meant to be used with the Vocabulary class, but the default can actually be changed to any child class of Ontology for most of them, so I'll use get_equivalent_terms(ontology_class='Signature') here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just closed KBDEV-1263

Copy link
Collaborator

@elewis2 elewis2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could signatures be added to the report data for tests in test_upload? In an ideal world test_main as well but test_upload at least will not run automatically so won't hold up github actions while ipr-api prod is not yet updated

Copy link
Contributor

@dustinbleile dustinbleile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem fine.

My only questions would be that there seem to be other similar categories like TMB_HIGH_CATEGORY. Are these signture categories something completely different or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants