Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PocketBeagle floating inputs should have RX disabled #201

Open
jadonk opened this issue Apr 6, 2019 · 2 comments
Open

PocketBeagle floating inputs should have RX disabled #201

jadonk opened this issue Apr 6, 2019 · 2 comments
Assignees
@jadonk
Labels
pocket PocketBeagle

Comments

@jadonk
Copy link
Member

jadonk commented Apr 6, 2019

The pinmux for P1.2 and P2.35 should be set to RX disabled for the case where an analog input is provided on those pins floating between 0V and 3.3V. Otherwise, there is extra I/O cell leakage.

http://processors.wiki.ti.com/index.php/AM335x_Schematic_Checklist
@jadonk jadonk self-assigned this Apr 6, 2019
@pdp7
Copy link
Contributor

pdp7 commented Jun 9, 2020

@jadonk do you mean disabled by kernel driver?

@pdp7 pdp7 added the pocket PocketBeagle label Jun 10, 2020
@pdp7
Copy link
Contributor

pdp7 commented Jul 8, 2020

@jadonk I think you mean setting the mux mode to have RX disabled in the device tree
Per the cape header pins sheet, I believe P1.02 / AIN6 / GPIO87 is:

  • mode0: lcd hsync
  • mode7: gpio 2.23

and P2.35 / AIN5 / GPIO86 is:

  • mode0: lcd vsync
  • mode7: gpio 2.22

Does that look right?

RobertCNelson pushed a commit that referenced this issue Feb 27, 2025
@geertu @gregkh
dma-mapping: save base/size instead of pointer to shared DMA pool
6989430 
commit 22293c3 upstream.

On RZ/Five, which is non-coherent, and uses CONFIG_DMA_GLOBAL_POOL=y:

    Oops - store (or AMO) access fault [#1]
    CPU: 0 UID: 0 PID: 1 Comm: swapper Not tainted 6.12.0-rc1-00015-g8a6e02d0c00e #201
    Hardware name: Renesas SMARC EVK based on r9a07g043f01 (DT)
    epc : __memset+0x60/0x100
     ra : __dma_alloc_from_coherent+0x150/0x17a
    epc : ffffffff8062d2bc ra : ffffffff80053a94 sp : ffffffc60000ba20
     gp : ffffffff812e9938 tp : ffffffd601920000 t0 : ffffffc6000d0000
     t1 : 0000000000000000 t2 : ffffffffe9600000 s0 : ffffffc60000baa0
     s1 : ffffffc6000d0000 a0 : ffffffc6000d0000 a1 : 0000000000000000
     a2 : 0000000000001000 a3 : ffffffc6000d1000 a4 : 0000000000000000
     a5 : 0000000000000000 a6 : ffffffd601adacc0 a7 : ffffffd601a841a8
     s2 : ffffffd6018573c0 s3 : 0000000000001000 s4 : ffffffd6019541e0
     s5 : 0000000200000022 s6 : ffffffd6018f8410 s7 : ffffffd6018573e8
     s8 : 0000000000000001 s9 : 0000000000000001 s10: 0000000000000010
     s11: 0000000000000000 t3 : 0000000000000000 t4 : ffffffffdefe62d1
     t5 : 000000001cd6a3a9 t6 : ffffffd601b2aad6
    status: 0000000200000120 badaddr: ffffffc6000d0000 cause: 0000000000000007
    [<ffffffff8062d2bc>] __memset+0x60/0x100
    [<ffffffff80053e1a>] dma_alloc_from_global_coherent+0x1c/0x28
    [<ffffffff80053056>] dma_direct_alloc+0x98/0x112
    [<ffffffff8005238c>] dma_alloc_attrs+0x78/0x86
    [<ffffffff8035fdb4>] rz_dmac_probe+0x3f6/0x50a
    [<ffffffff803a0694>] platform_probe+0x4c/0x8a

If CONFIG_DMA_GLOBAL_POOL=y, the reserved_mem structure passed to
rmem_dma_setup() is saved for later use, by saving the passed pointer.
However, when dma_init_reserved_memory() is called later, the pointer
has become stale, causing a crash.

E.g. in the RZ/Five case, the referenced memory now contains the
reserved_mem structure for the "mmode_resv0@30000" node (with base
0x30000 and size 0x10000), instead of the correct "pma_resv0@58000000"
node (with base 0x58000000 and size 0x8000000).

Fix this by saving the needed reserved_mem structure's contents instead.

Fixes: 8a6e02d ("of: reserved_mem: Restructure how the reserved memory regions are processed")
Signed-off-by: Geert Uytterhoeven <[email protected]>
Reviewed-by: Oreoluwa Babatunde <[email protected]>
Tested-by: Lad Prabhakar <[email protected]>
Signed-off-by: Christoph Hellwig <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jadonk jadonk

Labels
pocket PocketBeagle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jadonk @pdp7