Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for binaries #45

Open
yrashk opened this issue Jan 4, 2011 · 4 comments
Open

Add support for binaries #45

yrashk opened this issue Jan 4, 2011 · 4 comments
Labels

Comments

@yrashk
Copy link
Member

yrashk commented Jan 4, 2011

Not sure how exactly it should be done, binary-to-string? Special kind of object?

@yrashk
Copy link
Member Author

yrashk commented Jan 7, 2011

Should it be done at all? Given that its support is now available through externs?

@benoitc
Copy link

benoitc commented Sep 2, 2011

Most of json objects arehandled in binaries.

actually if I do :

27> Global:set_value("obj",erlv8_object:new([{<<"test">>, <<"test">>}])).
{erlv8_object,[{<<"test">>,<<"test">>}],undefined}
28> Obj3 = Global:get_value("obj"). 
undefined

It won't work which is quite annoying.

@yrashk
Copy link
Member Author

yrashk commented Sep 2, 2011

Good catch. Will fix.

@yrashk
Copy link
Member Author

yrashk commented Sep 8, 2011

@benoitc, done in 906f10c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants