Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add data intent does not support input of hh:mm #546

Open
krugerk opened this issue Dec 9, 2024 · 1 comment
Open

add data intent does not support input of hh:mm #546

krugerk opened this issue Dec 9, 2024 · 1 comment
Labels
RFE Request For Enhancement aka feature request

Comments

@krugerk
Copy link
Contributor

krugerk commented Dec 9, 2024

The website allows for various input formats, such as integers, decimals, "hh:mm", and even fractions.

The app supports sort of these (not yet fractions, see #418, and there are bugs surrounding the timey format, see #383).

One of these that is supported elsewhere in the app, the hh:mm as input, appears not to be supported via the add data intent, the add data app shortcut.

"7:51" passed to it would be reported upstream (to the backend) as 7. This is likely due to the value being declared as a decimal type.

Support input formats in the add data intent as are allowed elsewhere in the app.

Cognata

Verbata: timey-wimey format,

@krugerk krugerk added the BUG Opposite of feature label Dec 9, 2024
@dreeves dreeves added RFE Request For Enhancement aka feature request and removed BUG Opposite of feature labels Dec 13, 2024
@krugerk
Copy link
Contributor Author

krugerk commented Jan 8, 2025

The datapoint is being created using the "post to datapoints.json using urtext":

let _ = try await ServiceLocator.requestManager.addDatapoint(urtext: "^ \(value) \"\(comment)\"", slug: goalSlug)

so maybe it is fine to switch value in the add data intent from decimal to string and have the beeminder backend parse the contents of the string.
<string>Decimal</string>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFE Request For Enhancement aka feature request
Projects
None yet
Development

No branches or pull requests

2 participants