Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery cell graph border and safesum text in different colors #573

Open
krugerk opened this issue Dec 27, 2024 · 2 comments · May be fixed by #585
Open

Gallery cell graph border and safesum text in different colors #573

krugerk opened this issue Dec 27, 2024 · 2 comments · May be fixed by #585
Labels
BUG Opposite of feature

Comments

@krugerk
Copy link
Contributor

krugerk commented Dec 27, 2024

In the gallery collection view cells are shown one per goal. Each shows a thumbnail of the goal's graph as well as some text. The safesum is displayed in the countdown color and the border of the thumbnail is also colored.

For the red and greens these looked similar enough to me but the yellow appeared to be different and was off enough to appear to me to be a visual glitch.

These three looked similar enough:
image
image
image

This one, however, looks broken:
image
Though dark mode seems less problematic
image

ios 18.2
iphone 15 pro
app 6.7 (54)

@krugerk krugerk added the BUG Opposite of feature label Dec 27, 2024
@krugerk
Copy link
Contributor Author

krugerk commented Dec 27, 2024

The app uses its own colors for safesum to be legible on dark and light.
Meanwhile the border around the thumbnail is provided by the server: bmndr.com/username/goalname-thumb.png

@krugerk krugerk changed the title Gallery cell graph border and safesum text color different colors Gallery cell graph border and safesum text in different colors Dec 27, 2024
@krugerk
Copy link
Contributor Author

krugerk commented Dec 29, 2024

The app could scrape the border from the thumbnail image provided by the server, placing a border it creates around the image.

It could also grab the full image bmndr.com/username/goalname.png and wrap a border around that, using it in place of the thumbnail.

These could be implemented immediately.

Of course another solution could be one where the server plays a role as well, especially considering this is the report of the official beeminder ios app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Opposite of feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant