Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failure to delete benchmark #458

Closed
OmarTawfik opened this issue Jul 19, 2024 · 3 comments
Closed

failure to delete benchmark #458

OmarTawfik opened this issue Jul 19, 2024 · 3 comments

Comments

@OmarTawfik
Copy link
Contributor

OmarTawfik commented Jul 19, 2024

The UI displays the following error:

🐰 Lettuce romaine calm! Failed to delete. Please, try again.

And inspecting dev console, I see:

  • Request: DELETE https://api.bencher.dev/v0/projects/{PROJECT}/benchmarks/{NAME}
  • Status Code: 409 CONFLICT
  • X-Request-Id: 9e5de9f0-16ab-406b-bbe1-aa8a703b55c5
  • Fly-Request-Id: 01J35GYD2BG4WVZE38TVR6KXDS-sea

The error is persisting across many retries.

@epompeii
Copy link
Member

@OmarTawfik sorry you are running into trouble.

I searched for the X-Request-Id in the logs and it lead me to the slang project.
It looks like you still have a Report that uses the ======= CALLGRIND ======================================================= benchmark.

You have to delete all of the Reports and Thresholds that are associated with a Benchmark before you a can delete the Benchmark itself.

There are two outstanding issues to help make this a bit easier:

@OmarTawfik
Copy link
Contributor Author

I see. Thanks for explaining. I can delete the reports first, then delete the benchmark.

There are two outstanding issues to help make this a bit easier:

I think the main issue here is that the error message didn't tell me what was going on.
But please feel free to triage/close this issue if you are already tracking this somewhere else.

@epompeii
Copy link
Member

Great!

And yes the error messages could definitely be improved. Current tracking issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants