Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage outsite Home Assistant / SureHA #221

Open
lp55 opened this issue Feb 20, 2025 · 0 comments
Open

Usage outsite Home Assistant / SureHA #221

lp55 opened this issue Feb 20, 2025 · 0 comments
Labels
question Further information is requested

Comments

@lp55
Copy link
Collaborator

lp55 commented Feb 20, 2025

Hi,

Does anyone else uses this library other then Home Assistant / SureHA?

I ask this as I started writing tests for SurePy and taking a look at the functions, I noticed that SureHA calls only a couple of functions. So SurePy could be greatly simplified, by removing unused functions.

Also I think the structure of SurePy could be improved by better separating the SurePet API calls and data the conversion to proper python data structures. This would make for more clean tests, as one set of tests could test if the API calls return the expected json schema and another set of tests validates that the conversion is properly done.

Any comments?

@lp55 lp55 added the question Further information is requested label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant