You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I ask this as I started writing tests for SurePy and taking a look at the functions, I noticed that SureHA calls only a couple of functions. So SurePy could be greatly simplified, by removing unused functions.
Also I think the structure of SurePy could be improved by better separating the SurePet API calls and data the conversion to proper python data structures. This would make for more clean tests, as one set of tests could test if the API calls return the expected json schema and another set of tests validates that the conversion is properly done.
Any comments?
The text was updated successfully, but these errors were encountered:
Hi,
Does anyone else uses this library other then Home Assistant / SureHA?
I ask this as I started writing tests for SurePy and taking a look at the functions, I noticed that SureHA calls only a couple of functions. So SurePy could be greatly simplified, by removing unused functions.
Also I think the structure of SurePy could be improved by better separating the SurePet API calls and data the conversion to proper python data structures. This would make for more clean tests, as one set of tests could test if the API calls return the expected json schema and another set of tests validates that the conversion is properly done.
Any comments?
The text was updated successfully, but these errors were encountered: