Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is fdir faster? #79

Closed
balupton opened this issue Oct 28, 2020 · 4 comments
Closed

is fdir faster? #79

balupton opened this issue Oct 28, 2020 · 4 comments

Comments

@balupton
Copy link
Member

balupton commented Oct 28, 2020

http://npmjs.com/package/fdir
https://github.com/thecodrr/fdir

if it is faster, then move https://github.com/bevry/scandirectory over to it, and archive this project

@balupton balupton transferred this issue from bevry/scandirectory Oct 28, 2020
@balupton
Copy link
Member Author

Actually, the new recursive option in readdir is faster:
https://nodejs.org/api/fs.html#fspromisesreaddirpath-options
thecodrr/fdir#66 (comment)

@balupton
Copy link
Member Author

Rewrote readdir-cluster with v6, and yes, fdir takes 1/5 of the time of readdir-cluster, so it is faster. However fdir has the same performance as recursive option with the readdir builtin.

Mentioned this in the readme.

@danielbayley
Copy link

Actually, the new recursive option in readdir is faster

However fdir has the same performance as recursive option with the readdir builtin.

@balupton Is this actually true? According to the fdir benchmarks, fs.readdir is %83.27 slower… What did you find?

@balupton
Copy link
Member Author

balupton commented Apr 2, 2024

@danielbayley

Mentioned this in the readme.

See this project's readme for the benchmarks that I ran.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants