Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some bugs #1

Open
afarhangi opened this issue May 11, 2018 · 3 comments
Open

Some bugs #1

afarhangi opened this issue May 11, 2018 · 3 comments

Comments

@afarhangi
Copy link

Your linked_list.lenght has a bug for list of size 1. Also, your get calls length which does an extra O(n) iteration just to check if index is valid.

@bfaure
Copy link
Owner

bfaure commented May 11, 2018

What is the bug for a list of size 1? I have tested inserting a single element and calling the .length() function and it returns 1 as it should.

The assertion calls to .length() in .get and .erase are certainly inefficient but I hesitate to remove them because I would like to keep the code as similar to that taught in the video as possible. That being said, removing them won't cause any issues as long as the edge cases they protect against are caught inside the while loops.

Thanks for the input!

@mdhussain7
Copy link

a = linked_list()
a.append(1)
a.append(2)
a.append(3)
a.append(4)
a.aapend(5)
a.append(6)

a.display()
a.remove(1)
a.display()  

after the code

I got This error

> Traceback (most recent call last):
>   File "SinglyLinkedList.py", line 59, in <module>
>     a = LinkedList()
>   File "SinglyLinkedList.py", line 8, in __init__
>     self.head = node()
> TypeError: __init__() missing 1 required positional argument: 'data'

Can you help me with it?

@uncleSlayer
Copy link

self.head=node()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants