Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI is case insensitive on hostname #3

Open
reekoheek opened this issue Jan 8, 2012 · 0 comments
Open

URI is case insensitive on hostname #3

reekoheek opened this issue Jan 8, 2012 · 0 comments

Comments

@reekoheek
Copy link

You are using url.parse to parse URI (as camel URL terminology known as URI), it is good call reusing common lib.
But the fact is that url.parse return a case insensitive form of hostname.
It makes your example goes wrong,

var obj = require('./myObj');
require('donkey-obj/ObjectResolver').register('myObj',new obj());

as you are registering obj as myObj not as myobj.

I think it is good practice to write URI as lowered-case insensitive value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant