Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ray's impact parameter to light_ray_solution dictionary #8

Open
clairekope opened this issue Oct 18, 2021 · 1 comment
Open

Add ray's impact parameter to light_ray_solution dictionary #8

clairekope opened this issue Oct 18, 2021 · 1 comment

Comments

@clairekope
Copy link

Having recently discovered where Trident stores ray metadata (see https://trident.readthedocs.io/en/latest/light_ray_generator.html#examining-lightray-solution-data), the impact parameter used to generate the ray should also be stored here if at all possible. Or if not in this existing datastructure, than as an HDF5 attribute or something. This will replace the need to store a separate impact_parameter.npy file.

@biboyd
Copy link
Owner

biboyd commented Oct 25, 2021

That makes sense to do and would be a lot cleaner. Having that separate file was always a janky workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants