Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PET data: 'ReconFilterSize' expected but NOT required when 'ReconFilterType' is "none" #1585

Open
arovai opened this issue Jan 19, 2023 · 2 comments
Labels

Comments

@arovai
Copy link

arovai commented Jan 19, 2023

bids-validator v1.9.9 on a dataset with PET images.
As per BIDS doc for PET, the field ReconFilterSize is required only when ReconFilterType is not "none".
On my data, there is no recon filter (empty dicom tag), so my json contains:
"ReconFilterType": "none"
Still, bids-validator gives me the following error:

1: [ERR] Invalid JSON file. The file is not formatted according the schema. (code: 55 - JSON_SCHEMA_VALIDATION_ERROR)
		./sub-001/pet/sub-001_pet.json
			Evidence:  should have required property 'ReconFilterSize'

Maybe I am not entering the "none" value correctly (I have tried some variations like None, none, "n/a", n/a... without luck), or maybe bids-validator misses this case.
Any guess?

@effigies
Copy link
Collaborator

@arovai
Copy link
Author

arovai commented Jan 20, 2023

Hum, that's weird, I have tried having

    "ReconFilterType": "n/a",
    "ReconFilterSize": "n/a",

but this still gives me a bunch of errors:

		./sub-001/pet/sub-001_pet.json
			Evidence: .ReconFilterSize should be number
		./sub-001/pet/sub-001_pet.json
			Evidence: .ReconFilterSize should be array
		./sub-001/pet/sub-001_pet.json
			Evidence: .ReconFilterSize should match some schema in anyOf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants