Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent behavior for files of the form <suffix>.json files when in the root of the dataset #1631

Open
Remi-Gau opened this issue Feb 22, 2023 · 2 comments
Labels

Comments

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Feb 22, 2023

For some data types the validator is fine with having <suffix>.json files in the root of the dataset:

  • pet.json
  • T1.json

But for some others it will throw an error:

  • eeg.json
  • nirst.json
  • asl.json

Neither of those lists is exhaustive.

It would be preferable for this behavior to be consistent.

@Remi-Gau
Copy link
Contributor Author

thinking of a way to systematically test for this:

I could maybe add a script to run in CI that adds a .json to some of the example datasets and checks if the validator accepts them.

@effigies
Copy link
Collaborator

The inheritance principle is applied systematically in the schema validator, not based on hand-written regular expressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants