Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inheritance principle fails on physio.json #1632

Open
noah10 opened this issue Feb 23, 2023 · 2 comments
Open

inheritance principle fails on physio.json #1632

noah10 opened this issue Feb 23, 2023 · 2 comments
Labels
bug inheritance issues related to the inheritance principle json-schema All issues that involve work with the JSON-schema files legacy

Comments

@noah10
Copy link

noah10 commented Feb 23, 2023

I have a dataset that includes physio (respiratory) data and eeg data. Per the inheritance principle I put all of the physio.json values that don’t change across subjects/sessions into a physio.json file that is a sibling to the subject directories, and put subject-/session-/task-specific *physio.json files that include the required StartTime parameter (which does vary by subject/session) into the subject/session directories. The validator complains that the top-level physio.json file is missing the required StartTime parameter.

This happened using bids-validator 1.10, both from the bids-validator npm package and https://bids-standard.github.io/bids-validator/ .

Here's the relevant portion of the log output:

bids-validator eeg-physio
[email protected]
	1: [ERR] Invalid JSON file. The file is not formatted according the schema. (code: 55 - JSON_SCHEMA_VALIDATION_ERROR)
		./physio.json
			Evidence:  should have required property 'StartTime'
@effigies
Copy link
Collaborator

This definitely seems like a bug where we're directly validating JSON files instead of compiled sidecars. This should be resolved when we transition to the schema validator, but would it be difficult to fix this in the short term?

cc @sappelhoff @rwblair

@effigies effigies added bug json-schema All issues that involve work with the JSON-schema files labels Feb 23, 2023
@sappelhoff sappelhoff added the inheritance issues related to the inheritance principle label Jun 21, 2023
@effigies
Copy link
Collaborator

This should be resolved in the schema validator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug inheritance issues related to the inheritance principle json-schema All issues that involve work with the JSON-schema files legacy
Projects
None yet
Development

No branches or pull requests

3 participants