-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] add support for qMRI json in top dir #1546
Conversation
Codecov ReportBase: 83.27% // Head: 83.17% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1546 +/- ##
==========================================
- Coverage 83.27% 83.17% -0.10%
==========================================
Files 91 91
Lines 3742 3763 +21
Branches 1144 1158 +14
==========================================
+ Hits 3116 3130 +14
- Misses 528 535 +7
Partials 98 98
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
OK trying to test but I am failing to do it locally against this PR bids-standard/bids-examples#337 of the bids-example |
@Remi-Gau each top rule still had one required entity, I made those all optional and removed the anat_top entries. |
note to self: still getting an error for the MP2RAGE dataset |
Note that maybe we may actually want to keep the required entities in the name. For example, it seems that the validator does not accept a bare |
partly related to https://github.com/bids-standard/bids-validator/issues/1631 |
Seems that all the modified datasets in the bids examples are not OK with this. Thanks @rwblair Merge whenever you want |
The error is still present for |
No. Can you open a PR? I started a bit back on basing the Python validator on the schema, which should make it less susceptible to these errors of omission. I got stalled by bids-standard/bids-specification#1672. |
relates to #1438
[_acq-<label>][_ce-<label>][_rec-<label>][_run-<index>]_echo-<index>[_part-<mag|phase|real|imag>]_MEGRE.json
[_acq-<label>][_ce-<label>][_rec-<label>][_run-<index>]_echo-<index>[_part-<mag|phase|real|imag>]_MESE.json
[_acq-<label>][_ce-<label>][_rec-<label>][_run-<index>][_echo-<index>]_flip-<index>[_part-<mag|phase|real|imag>]_VFA.json
[_acq-<label>][_ce-<label>][_rec-<label>][_run-<index>]_inv-<index>[_part-<mag|phase|real|imag>]_IRT1.json
[_acq-<label>][_ce-<label>][_rec-<label>][_run-<index>][_echo-<index>][_flip-<index>]_inv-<index>[_part-<mag|phase|real|imag>]_MP2RAGE.json
[_acq-<label>][_ce-<label>][_rec-<label>][_run-<index>][_echo-<index>]_flip-<index>_mt-<on|off>[_part-<mag|phase|real|imag>]_MPM.json
[_acq-<label>][_ce-<label>][_rec-<label>][_run-<index>][_echo-<index>]_flip-<index>_mt-<on|off>[_part-<mag|phase|real|imag>]_MTS.json
[_acq-<label>][_ce-<label>][_rec-<label>][_run-<index>]_mt-<on|off>[_part-<mag|phase|real|imag>]_MTR.json
unrelated
add
ce
entity for anat filesTODO