Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form error state for material thickness #13

Open
iammikecohen opened this issue Jan 5, 2025 · 1 comment
Open

Form error state for material thickness #13

iammikecohen opened this issue Jan 5, 2025 · 1 comment

Comments

@iammikecohen
Copy link

If I opened a PR would you consider this change:

When a material thickness greater than the height of the bit is entered display an error rather than changing the material thickness to the bit height.

It should be obvious that you can’t cut a material thicker than your bit. However, I wasn’t thinking and didn’t see the form update. I can imagine others running into the same problem.

My proposed change would disable the SVG download buttons and display error text under the material thickness form field.

@bieber
Copy link
Owner

bieber commented Jan 5, 2025

Yeah, that sounds great. If you want to send something over I'd be glad to take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants