Skip to content

New manifest contains unexplained link to a CDN (which doesn't even have a valid certificate) #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ithanil opened this issue Oct 30, 2024 · 3 comments · May be fixed by #8
Open

Comments

@Ithanil
Copy link

Ithanil commented Oct 30, 2024

The new manifest file contains a key localesBaseUrl which has as value an URL to a CDN, for which is not explained what the purpose of this is, who operates the CDN, what content is hosted there and especially not how to replace this with a self-hosted solution. Also the site does not even provide a certificate.

"localesBaseUrl": "https://cdn.dominio.com/pluginabc/",

Please put the contents into this repository and explain a bit what is going on here.

@GuiLeme
Copy link
Collaborator

GuiLeme commented Jan 28, 2025

Hello, @Ithanil , thank you for pointing that out! We are going to take care of this situation soon enough. But for all that matters, this key is the base URL for the CDN to the locales of that specific plugin (so: related to translations).

And you are right, that is currently not pointing anywhere yet, because this is just a mocked data. We'll implement the translations for this specific plugin (if needed, of course) in the near future.

@Ithanil
Copy link
Author

Ithanil commented Jan 28, 2025

Hi @GuiLeme , thanks for the response.

I would be happy to help with German translations. Since this plugin provides functionality that was part of the core before, for me it is a necessary prerequisite to rolling out BBB 3.0 and thus it needs German translations. ;-) Just so you know, being able to localize is quite important to us.

@GuiLeme
Copy link
Collaborator

GuiLeme commented Feb 12, 2025

Hello, @Ithanil, thank you for the patience! I just sent in a couple of PRs adding the locale feature to the Plugins and specially for this plugin:

If you want to, feel free to test already, but I'd recommend waiting for the merge of the PR in the CORE and in the plugin-SDK first.

Ping if anything comes up, and thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants