New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add databricks to dialect list #68

Closed

gabrielecalvo opened this issue Mar 17, 2025 · 0 comments · Fixed by #69

Contributor

gabrielecalvo commented Mar 17, 2025

I've noticed that dbt-ibis doesn't support databricks as a dialect, while both ibis does.

As far as I can understand it should be just a matter of adding a couple of lines of code after these:

dbt-ibis/dbt_ibis/_dialects.py

Line 25 in ce9079d

DBTAdapterType("risingwave"): IbisDialect("risingwave"),
dbt-ibis/dbt_ibis/_dialects.py

Line 37 in ce9079d

IbisDialect("risingwave"): sql_dt.RisingWaveType,

Would you be interested in me creating a PR for it?

The text was updated successfully, but these errors were encountered:

binste linked a pull request

that will close this issue

add databricks adapter #69

Merged

binste closed this as completed in #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment